-
Notifications
You must be signed in to change notification settings - Fork 109
Adds save dirty checking event #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds save dirty checking event #359
Conversation
|
IMO we should implement undo/redo instead. With undo/redo implemented, determining if the project has changed should be easy, and obviously it's also useful to be able to undo things. We could theoretically implement the two features separately, but that means that undoing and redoing something will still make the project "dirty" |
Current coverage is
|
I spent a few hours on it before. I agree that it's a feature that could be added. The events that are fired when an undo/redo event happens are the same events that this deals with so I'm not sure if the two are mutually exclusive. |
|
I think Dirty saves is a good feature to implement until we find a suitable way to go about undo/redo operations. I think both these features should be implemented in the near future. |
|
I agree with what @JacisNonsense said |
This provides a cleaner UI experience. You are now only requested to save when an event dirties the save file. The deployer now also ensures that you have not dirtied the save.
7fe93d4 to
2ccab9b
Compare
|
Before merging can we add a UI indicator that the pipeline is dirty? Many apps add an asterisk after the file name in the title bar to indicate the file is dirty. |
|
@AustinShalit How's this coming? |
|
#647 completes this feature. |
This provides a cleaner UI experience.
You are now only requested to save when an event dirties the save file.
The deployer now also ensures that you have not dirtied the save.